From ab5ac9d7969ec73354700670741e02098b23a597 Mon Sep 17 00:00:00 2001
From: Sutra Zhou <zhoushuqun@gmail.com>
Date: Thu, 28 May 2020 19:05:17 +0800
Subject: [PATCH] Fix test failure and javadoc failure.

---
 pom.xml                                       | 19 +++++++++++--------
 .../webmagic/selector/RegexSelector.java      |  2 +-
 webmagic-scripts/pom.xml                      | 16 ----------------
 3 files changed, 12 insertions(+), 25 deletions(-)

diff --git a/pom.xml b/pom.xml
index eca2523..06a3213 100644
--- a/pom.xml
+++ b/pom.xml
@@ -7,8 +7,8 @@
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+        <java.version>1.8</java.version>
         <spring-version>4.0.0.RELEASE</spring-version>
-
     </properties>
     <artifactId>webmagic-parent</artifactId>
     <name>webmagic-parent</name>
@@ -103,7 +103,7 @@
             <dependency>
                 <groupId>com.alibaba</groupId>
                 <artifactId>fastjson</artifactId>
-                <version>1.2.28</version>
+                <version>1.2.56</version>
             </dependency>
             <dependency>
                 <groupId>com.github.dreamhead</groupId>
@@ -162,7 +162,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
-                <version>2.18</version>
+                <version>3.0.0-M4</version>
                 <configuration>
                     <forkCount>0</forkCount>
                 </configuration>
@@ -170,11 +170,10 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.1</version>
+                <version>3.7.0</version>
                 <configuration>
-                    <source>1.6</source>
-                    <target>1.6</target>
-                    <encoding>UTF-8</encoding>
+                    <source>${java.version}</source>
+                    <target>${java.version}</target>
                 </configuration>
             </plugin>
             <!--<plugin>-->
@@ -230,11 +229,15 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-javadoc-plugin</artifactId>
-                <version>2.10.4</version>
+                <version>3.2.0</version>
                 <configuration>
                     <encoding>UTF-8</encoding>
                     <doctitle>WebMagic 0.7.3</doctitle>
                     <locale>en_US</locale>
+
+                    <!-- avoid the issue: https://bugs.openjdk.java.net/browse/JDK-8212233 -->
+                    <detectJavaApiLink>false</detectJavaApiLink>
+
                 </configuration>
                 <executions>
                     <execution>
diff --git a/webmagic-core/src/main/java/us/codecraft/webmagic/selector/RegexSelector.java b/webmagic-core/src/main/java/us/codecraft/webmagic/selector/RegexSelector.java
index 9ae538c..fb0a161 100644
--- a/webmagic-core/src/main/java/us/codecraft/webmagic/selector/RegexSelector.java
+++ b/webmagic-core/src/main/java/us/codecraft/webmagic/selector/RegexSelector.java
@@ -41,7 +41,7 @@ public class RegexSelector implements Selector {
 
     /**
      * Create a RegexSelector. When there is no capture group, the value is set to 0 else set to 1.
-     * @param regexStr
+     * @param regexStr the regular expression.
      */
     public RegexSelector(String regexStr) {
         this.compileRegex(regexStr);
diff --git a/webmagic-scripts/pom.xml b/webmagic-scripts/pom.xml
index 9dbc7b3..94f08f0 100755
--- a/webmagic-scripts/pom.xml
+++ b/webmagic-scripts/pom.xml
@@ -7,7 +7,6 @@
     </parent>
     <modelVersion>4.0.0</modelVersion>
 
-    <groupId>us.codecraft</groupId>
     <artifactId>webmagic-scripts</artifactId>
     <properties>
         <kotlin.version>1.1.2-2</kotlin.version>
@@ -63,21 +62,6 @@
     <build>
         <sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
         <plugins>
-            <plugin>
-                <artifactId>maven-compiler-plugin</artifactId>
-                <configuration>
-                    <source>1.6</source>
-                    <target>1.6</target>
-                    <encoding>UTF-8</encoding>
-                </configuration>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-resources-plugin</artifactId>
-                <configuration>
-                    <encoding>UTF-8</encoding>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>