Mobai
/
magic-Dependency
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pass exception to onError. Fixes #1005.

master
Sutra Zhou 2021-03-22 18:18:10 +08:00
parent dcfd238413
commit 4e8a086dae
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
webmagic-core/src/main/java/us/codecraft/webmagic/Spider.java
View File

@ -320,7 +320,7 @@ public class Spider implements Runnable, Task {
processRequest(request);
onSuccess(request);
} catch (Exception e) {
onError(request);
onError(request, e);
logger.error("process request " + request + " error", e);
} finally {
pageCount.incrementAndGet();
@ -338,10 +338,19 @@ public class Spider implements Runnable, Task {
logger.info("Spider {} closed! {} pages downloaded.", getUUID(), pageCount.get());
}
/**
* @deprecated Use {@link #onError(Request, Exception)} instead.
*/
@Deprecated
protected void onError(Request request) {
}
protected void onError(Request request, Exception e) {
this.onError(request);
if (CollectionUtils.isNotEmpty(spiderListeners)) {
for (SpiderListener spiderListener : spiderListeners) {
spiderListener.onError(request);
spiderListener.onError(request, e);
}
}
}

9
webmagic-core/src/main/java/us/codecraft/webmagic/SpiderListener.java
View File

@ -10,5 +10,14 @@ public interface SpiderListener {
public void onSuccess(Request request);
/**
* @deprecated Use {@link #onError(Request, Exception)} instead.
*/
@Deprecated
public void onError(Request request);
default void onError(Request request, Exception e) {
this.onError(request);
}
}